63883dc0c - platform/development

commit: 63883dc0cb9b026b057f85200f4511fc8538d4be
[log] [tgz]
author: Priyanka <priyankaspatel@google.com>
Mon Nov 06 16:41:13 2023 +0000
committer: Priyanka <priyankaspatel@google.com>
Wed Nov 08 13:04:07 2023 +0000
tree: e193688b301b8c139fbad75846158459d1d042f2
parent: a2664699e57875934a3b7b4d8a417bdfb41a149e [diff]

Fix filenameFormControl issue.

makeDownloadArchiveFilename contained no checks to make sure the returned string was valid according to FileUtils.DOWNLOAD_FILENAME_REGEX.
Introduced these checks, and also initialised filenameFormControl in AppComponent to avoid future issues with it not being defined in places.

Bug: b/309431531
Test: npm run test:unit:ci
Change-Id: Ic996b18d92b65bf937a87a4630e08a0d6e7fc024

tools/winscope/src/app/components/app_component.ts[diff]
tools/winscope/src/app/trace_pipeline.ts[diff]
tools/winscope/src/app/trace_pipeline_test.ts[diff]
tools/winscope/src/common/file_utils.ts[diff]
tools/winscope/src/test/fixtures/traces/SF_trace&(*_with:_illegal+_characters.pb[Added - diff]

5 files changed

tree: e193688b301b8c139fbad75846158459d1d042f2