Increase minimum slider size
Change-Id: I96e5848dd12f79ab0c43d31d6329133c89abdc46
diff --git a/tools/winscope/src/app/components/timeline/mini-timeline/slider_component.ts b/tools/winscope/src/app/components/timeline/mini-timeline/slider_component.ts
index 1a2130e..e2b3da1 100644
--- a/tools/winscope/src/app/components/timeline/mini-timeline/slider_component.ts
+++ b/tools/winscope/src/app/components/timeline/mini-timeline/slider_component.ts
@@ -185,13 +185,12 @@
}
computeSliderWidth() {
- const minSliderWidth = 15;
const transformer = this.getTransformer();
let width =
transformer.transform(assertDefined(this.zoomRange).to) -
transformer.transform(assertDefined(this.zoomRange).from);
- if (width < minSliderWidth) {
- width = minSliderWidth;
+ if (width < MIN_SLIDER_WIDTH) {
+ width = MIN_SLIDER_WIDTH;
}
return width;
@@ -291,3 +290,5 @@
addEventListener('mouseup', mouseUpListener);
}
}
+
+export const MIN_SLIDER_WIDTH = 50;
diff --git a/tools/winscope/src/app/components/timeline/mini-timeline/slider_component_test.ts b/tools/winscope/src/app/components/timeline/mini-timeline/slider_component_test.ts
index 758609d..4c5d288 100644
--- a/tools/winscope/src/app/components/timeline/mini-timeline/slider_component_test.ts
+++ b/tools/winscope/src/app/components/timeline/mini-timeline/slider_component_test.ts
@@ -30,7 +30,7 @@
import {dragElement} from 'test/utils';
import {RealTimestamp} from 'trace/timestamp';
import {TracePosition} from 'trace/trace_position';
-import {SliderComponent} from './slider_component';
+import {MIN_SLIDER_WIDTH, SliderComponent} from './slider_component';
describe('SliderComponent', () => {
let fixture: ComponentFixture<SliderComponent>;
@@ -116,11 +116,9 @@
});
fixture.detectChanges();
- const minWidth = 15;
-
const sliderWidth = component.sliderBox.nativeElement.offsetWidth;
- expect(component.sliderWidth).toBe(minWidth);
- expect(component.dragPosition.x).toBe(sliderWidth / 4 - minWidth / 2);
+ expect(component.sliderWidth).toBe(MIN_SLIDER_WIDTH);
+ expect(component.dragPosition.x).toBe(sliderWidth / 4 - MIN_SLIDER_WIDTH / 2);
});
it('repositions slider on resize', () => {
