commit ba587f9b33109c8cbcb4cf93c21036a8063ea580
author Elliott Hughes <enh@google.com> Thu Mar 31 11:06:36 2011 -0700
committer Elliott Hughes <enh@google.com> Thu Mar 31 11:06:36 2011 -0700
tree 3c8cc8338c95936c274362e3fe1f47b649a6edf7
parent a1cfe9e4487ca2d17090bd9899620099aa358b80

Improve diagnostics when non-String passed as a jstring.

For my particular bug, the cause was obvious by inspection of the calling
code, but this might be useful in harder cases.

Before:
    W(17868) JNI WARNING: jstring 0x3600001 points to non-string object (Check_GetStringUTFChars)  (dalvikvm)

Change-Id: I883a99936b8c2cd79c5a691f7c335245ff50b34f
After:
    W(19680) JNI WARNING: jstring 0x3600001 points to object of type Llibcore/io/Posix; (Check_GetStringUTFChars)  (dalvikvm)

vm/CheckJni.c

diff --git a/vm/CheckJni.c b/vm/CheckJni.c
index 76ad85b..5478eb1 100644
--- a/vm/CheckJni.c
+++ b/vm/CheckJni.c
@@ -583,8 +583,8 @@
          * we're doing it again over in checkObject().
          */
         if (dvmIsValidObject(obj))
-            LOGW("JNI WARNING: jstring %p points to non-string object (%s)",
-                jstr, func);
+            LOGW("JNI WARNING: jstring %p points to object of type %s (%s)",
+                jstr, obj->clazz->descriptor, func);
         else
             LOGW("JNI WARNING: jstring %p is not a valid object (%s)", jstr,
                 func);