commit 80b29178e2c9593f04a3f10b895e802999073698
author Barry Hayes <bhayes@google.com> Tue Apr 20 09:03:15 2010 -0700
committer Barry Hayes <bhayes@google.com> Wed May 19 09:44:55 2010 -0700
tree 74bca33869f1643687938c7d58e88e33fc39598f
parent 8bb533e726c477d4982b30d01d19c0cda5fa7fb6

Improvements to setThreadSelf use.

Made all calls to assignThreadId and prepareThread aquire
threadListLock, even in initialization, where it previously relied on
being single-threaded.

Change-Id: Ibffc454c4c6fd78efa6f22b955b955cd33998a4c

vm/Thread.c

diff --git a/vm/Thread.c b/vm/Thread.c
index b512de3..6410bb4 100644
--- a/vm/Thread.c
+++ b/vm/Thread.c
@@ -989,7 +989,7 @@
  * This must be called while executing in the new thread, but before the
  * thread is added to the thread list.
  *
- * *** NOTE: The threadListLock must be held by the caller (needed for
+ * NOTE: The threadListLock must be held by the caller (needed for
  * assignThreadId()).
  */
 static bool prepareThread(Thread* thread)
@@ -1000,6 +1000,10 @@
 
     //LOGI("SYSTEM TID IS %d (pid is %d)\n", (int) thread->systemTid,
     //    (int) getpid());
+    /*
+     * If we were called by dvmAttachCurrentThread, the self value is
+     * already correctly established as "thread".
+     */
     setThreadSelf(thread);
 
     LOGV("threadid=%d: interp stack at %p\n",
@@ -1194,8 +1198,7 @@
  *
  * We reserve zero for use as an invalid ID.
  *
- * This must be called with threadListLock held (unless we're still
- * initializing the system).
+ * This must be called with threadListLock held.
  */
 static void assignThreadId(Thread* thread)
 {
@@ -1623,6 +1626,7 @@
     /*
      * Finish initializing the Thread struct.
      */
+    dvmLockThreadList(self);
     prepareThread(self);
 
     LOG_THREAD("threadid=%d: created from interp\n", self->threadId);
@@ -1631,7 +1635,6 @@
      * Change our status and wake our parent, who will add us to the
      * thread list and advance our state to VMWAIT.
      */
-    dvmLockThreadList(self);
     self->status = THREAD_STARTING;
     pthread_cond_broadcast(&gDvm.threadStartCond);