tree b9d13c84cdf2bd1f08a685c74b282ca9503081fd
parent a7ede4742d806015370b9443abb75dd9c9f4dda3
author Elliott Hughes <enh@google.com> 1252441156 -0700
committer Elliott Hughes <enh@google.com> 1252441926 -0700

Add missing calls to ReleaseByteArrayElements.

Without this fix, the two new tests cause the VM to abort like this:

W/dalvikvm(  386): ReferenceTable overflow (max=1024)
W/dalvikvm(  386): Last 10 entries in JNI pinned array reference table:
W/dalvikvm(  386):  1014: 0x4038e018 cls=[B (1044 bytes)
W/dalvikvm(  386):  1015: 0x4038e430 cls=[B (1044 bytes)
W/dalvikvm(  386):  1016: 0x4038e848 cls=[B (1044 bytes)
W/dalvikvm(  386):  1017: 0x4038ec60 cls=[B (1044 bytes)
W/dalvikvm(  386):  1018: 0x4038f078 cls=[B (1044 bytes)
W/dalvikvm(  386):  1019: 0x4038f490 cls=[B (1044 bytes)
W/dalvikvm(  386):  1020: 0x4038f8a8 cls=[B (1044 bytes)
W/dalvikvm(  386):  1021: 0x4038fcc0 cls=[B (1044 bytes)
W/dalvikvm(  386):  1022: 0x403900d8 cls=[B (1044 bytes)
W/dalvikvm(  386):  1023: 0x403904f0 cls=[B (1044 bytes)
W/dalvikvm(  386): JNI pinned array reference table summary (1024 entries):
W/dalvikvm(  386):  1024 of [B 1044B (1024 unique)
W/dalvikvm(  386): Memory held directly by native code is 1069056 bytes
E/dalvikvm(  386): Failed adding to JNI pinned array ref table (1024 entries)
I/dalvikvm(  386): "main" prio=5 tid=3 RUNNABLE
I/dalvikvm(  386):   | group="main" sCount=0 dsCount=0 s=N obj=0x4001e2b8 self=0xb488
I/dalvikvm(  386):   | sysTid=386 nice=0 sched=0/0 cgrp=default handle=-1344005452
I/dalvikvm(  386):   at org.apache.harmony.xnet.provider.jsse.OpenSSLSocketImpl.nativeinit(Native Method)
I/dalvikvm(  386):   at org.apache.harmony.xnet.provider.jsse.OpenSSLSocketImpl.init(OpenSSLSocketImpl.java:126)
I/dalvikvm(  386):   at org.apache.harmony.xnet.provider.jsse.OpenSSLSocketImpl.<init>(OpenSSLSocketImpl.java:158)
I/dalvikvm(  386):   at org.apache.harmony.xnet.provider.jsse.OpenSSLSocketFactoryImpl.createSocket(OpenSSLSocketFactoryImpl.java:61)
I/dalvikvm(  386):   at tests.api.javax.net.ssl.SSLSocketTest.test_creationStressTest(SSLSocketTest.java:359)
...

Tested on sapphire-eng.

No bug; found by inspection when investigating bug 1639287.