commit 584a181eedfb7049ba8c4cace5c9ba302883d140
author Andy McFadden <fadden@android.com> Wed Mar 16 11:19:55 2011 -0700
committer Andy McFadden <fadden@android.com> Wed Mar 16 12:02:07 2011 -0700
tree e450b453bb1473398d97a16044a9256b99c3804c
parent 1b4822ecb93021e6273c92093f78dcb6ccc0cf91

Update CheckJNI implementation

This implements a couple of "TODO" items that affect CheckJNI and
indirect references.  It also adds guards that were missing around
some tests that examine objects on the heap.

Change-Id: If80d19dafb3043aa1a1d287a660ae48c86c4baa0

vm/CheckJni.c

diff --git a/vm/CheckJni.c b/vm/CheckJni.c
index 5b9ea12..76ad85b 100644
--- a/vm/CheckJni.c
+++ b/vm/CheckJni.c
@@ -439,6 +439,7 @@
     }
 
     if (field->signature[0] == 'L' || field->signature[0] == '[') {
+        JNI_ENTER();
         Object* obj = dvmDecodeIndirectRef(env, jobj);
         if (obj != NULL) {
             ClassObject* fieldClass =
@@ -454,6 +455,7 @@
                 printWarn = true;
             }
         }
+        JNI_EXIT();
     } else if (dexGetPrimitiveTypeFromDescriptorChar(field->signature[0]) != prim) {
         LOGW("JNI WARNING: field '%s' with type '%s' set with wrong type (%s)",
             field->name, field->signature, primitiveTypeToName(prim));
@@ -804,6 +806,7 @@
  */
 static void checkStaticFieldID(JNIEnv* env, jclass jclazz, jfieldID fieldID)
 {
+    JNI_ENTER();
     ClassObject* clazz = (ClassObject*) dvmDecodeIndirectRef(env, jclazz);
     StaticField* base = &clazz->sfields[0];
     int fieldCount = clazz->sfieldCount;
@@ -816,6 +819,7 @@
         LOGW("             base=%p count=%d", base, fieldCount);
         abortMaybe();
     }
+    JNI_EXIT();
 }
 
 /*
@@ -1125,6 +1129,7 @@
 static void* createGuardedPACopy(JNIEnv* env, const jarray jarr,
     jboolean* isCopy)
 {
+    JNI_ENTER();
     ArrayObject* arrObj = (ArrayObject*) dvmDecodeIndirectRef(env, jarr);
     PrimitiveType primType = arrObj->obj.clazz->elementClass->primitiveType;
     int len = arrObj->length * dvmPrimitiveTypeWidth(primType);
@@ -1135,6 +1140,7 @@
     if (isCopy != NULL)
         *isCopy = JNI_TRUE;
 
+    JNI_EXIT();
     return result;
 }
 
@@ -1145,14 +1151,15 @@
 static void* releaseGuardedPACopy(JNIEnv* env, jarray jarr, void* dataBuf,
     int mode)
 {
+    JNI_ENTER();
     ArrayObject* arrObj = (ArrayObject*) dvmDecodeIndirectRef(env, jarr);
     bool release, copyBack;
-    u1* result;
+    u1* result = NULL;
 
     if (!checkGuardedCopy(dataBuf, true)) {
         LOGE("JNI: failed guarded copy check in releaseGuardedPACopy");
         abortMaybe();
-        return NULL;
+        goto bail;
     }
 
     switch (mode) {
@@ -1170,7 +1177,7 @@
     default:
         LOGE("JNI: bad release mode %d", mode);
         dvmAbort();
-        return NULL;
+        goto bail;
     }
 
     if (copyBack) {
@@ -1187,6 +1194,8 @@
     /* pointer is to the array contents; back up to the array object */
     result -= offsetof(ArrayObject, contents);
 
+bail:
+    JNI_EXIT();
     return result;
 }
 
@@ -1845,9 +1854,11 @@
     const jchar* result;
     result = BASE_ENV(env)->GetStringChars(env, string, isCopy);
     if (((JNIEnvExt*)env)->forceDataCopy && result != NULL) {
-        // TODO: fix for indirect
-        int len = dvmStringLen((StringObject*) string) * 2;
-        result = (const jchar*) createGuardedCopy(result, len, false);
+        JNI_ENTER();
+        StringObject* strObj = (StringObject*) dvmDecodeIndirectRef(env, string);
+        int byteCount = dvmStringLen(strObj) * 2;
+        JNI_EXIT();
+        result = (const jchar*) createGuardedCopy(result, byteCount, false);
         if (isCopy != NULL)
             *isCopy = JNI_TRUE;
     }
@@ -1901,9 +1912,7 @@
     const char* result;
     result = BASE_ENV(env)->GetStringUTFChars(env, string, isCopy);
     if (((JNIEnvExt*)env)->forceDataCopy && result != NULL) {
-        // TODO: fix for indirect
-        int len = dvmStringUtf8ByteLen((StringObject*) string) + 1;
-        result = (const char*) createGuardedCopy(result, len, false);
+        result = (const char*) createGuardedCopy(result, strlen(result)+1, false);
         if (isCopy != NULL)
             *isCopy = JNI_TRUE;
     }
@@ -2191,9 +2200,11 @@
     const jchar* result;
     result = BASE_ENV(env)->GetStringCritical(env, string, isCopy);
     if (((JNIEnvExt*)env)->forceDataCopy && result != NULL) {
-        // TODO: fix for indirect
-        int len = dvmStringLen((StringObject*) string) * 2;
-        result = (const jchar*) createGuardedCopy(result, len, false);
+        JNI_ENTER();
+        StringObject* strObj = (StringObject*) dvmDecodeIndirectRef(env, string);
+        int byteCount = dvmStringLen(strObj) * 2;
+        JNI_EXIT();
+        result = (const jchar*) createGuardedCopy(result, byteCount, false);
         if (isCopy != NULL)
             *isCopy = JNI_TRUE;
     }