commit 1c3e0976b756232d93d02f71ec1f1d4c2a79d3b3
author Carl Shapiro <cshapiro@google.com> Wed Dec 08 17:17:45 2010 -0800
committer Carl Shapiro <cshapiro@google.com> Wed Dec 08 17:19:29 2010 -0800
tree b91d48addd495ea213f2f3b8059e912ce08ad368
parent 3d0275b6afe60022abab3f860fd0f99b1a80dd44

Compare the buffer pointers to avoid signedness mismatches.

Previously, this code tried to traffick in buffer sizes.  It seems
that the results of the pointer arithmetic resulted in a signed value
while the buffer size constant was interpreted as an unsigned.

Change-Id: I1816fee9eae36f225d0480642ecc91ea7a2d0ad1

vm/alloc/HeapBitmap.c

diff --git a/vm/alloc/HeapBitmap.c b/vm/alloc/HeapBitmap.c
index 3ec5ab1..c5f3d18 100644
--- a/vm/alloc/HeapBitmap.c
+++ b/vm/alloc/HeapBitmap.c
@@ -123,7 +123,7 @@
             }
             /* Make sure that there are always enough slots available */
             /* for an entire word of 1s. */
-            if (NELEM(pointerBuf) - (pb - pointerBuf) < HB_BITS_PER_WORD) {
+            if (pb >= &pointerBuf[NELEM(pointerBuf) - HB_BITS_PER_WORD]) {
                 (*callback)(pb - pointerBuf, pointerBuf, callbackArg);
                 pb = pointerBuf;
             }