commit c8c5dedf096912d614d5d882ad818a05901874bd
author Usama Arif <usama.arif@linaro.org> Mon Nov 11 15:42:23 2019 +0000
committer Usama Arif <usama.arif@linaro.org> Wed Nov 13 10:33:15 2019 +0000
tree 8d18154a7b3d3c54ecf53382e47b3e247404329a
parent c2ebb8a05a4febcb760df5d6b424d8e8d87ea3e2

Fix incorrect Half comparison tests

This CL corrects the Half tests to perform the right comparison check
in the respecitive test functions. For example, the test
assertTrue(Half.lessEquals(NEGATIVE_INFINITY, NEGATIVE_INFINITY))
was being used in both HalfTest.lessEquals and HalfTest.greaterEquals and
assertTrue(Half.greaterEquals(NEGATIVE_INFINITY, NEGATIVE_INFINITY))
did not exist at all.

Test: cts-tradefed  run singleCommand cts-dev --module CtsUtilTestCases --test android.util.cts.HalfTest
Change-Id: Ibbf0c4350ec66157b6af3ab11193dbb22e22ba90

tests/tests/util/src/android/util/cts/HalfTest.java

diff --git a/tests/tests/util/src/android/util/cts/HalfTest.java b/tests/tests/util/src/android/util/cts/HalfTest.java
index ae08580..59e8774 100644
--- a/tests/tests/util/src/android/util/cts/HalfTest.java
+++ b/tests/tests/util/src/android/util/cts/HalfTest.java
@@ -406,7 +406,7 @@
 
     @Test
     public void lessEquals() {
-        assertTrue(Half.less(NEGATIVE_INFINITY, POSITIVE_INFINITY));
+        assertTrue(Half.lessEquals(NEGATIVE_INFINITY, POSITIVE_INFINITY));
         assertTrue(Half.lessEquals(MAX_VALUE, POSITIVE_INFINITY));
         assertFalse(Half.lessEquals(POSITIVE_INFINITY, MAX_VALUE));
         assertFalse(Half.lessEquals(LOWEST_VALUE, NEGATIVE_INFINITY));
@@ -421,7 +421,7 @@
         assertFalse(Half.lessEquals(toHalf(12.4f), toHalf(12.3f)));
         assertFalse(Half.lessEquals(toHalf(-12.3f), toHalf(-12.4f)));
         assertTrue(Half.lessEquals(toHalf(-12.4f), toHalf(-12.3f)));
-        assertTrue(Half.less(MIN_VALUE, (short) 0x3ff));
+        assertTrue(Half.lessEquals(MIN_VALUE, (short) 0x3ff));
         assertTrue(Half.lessEquals(NEGATIVE_INFINITY, NEGATIVE_INFINITY));
         assertTrue(Half.lessEquals(POSITIVE_INFINITY, POSITIVE_INFINITY));
         assertTrue(Half.lessEquals(toHalf(12.12356f), toHalf(12.12356f)));
@@ -465,11 +465,11 @@
         assertFalse(Half.greaterEquals(toHalf(12.3f), toHalf(12.4f)));
         assertFalse(Half.greaterEquals(toHalf(-12.4f), toHalf(-12.3f)));
         assertTrue(Half.greaterEquals(toHalf(-12.3f), toHalf(-12.4f)));
-        assertTrue(Half.greater((short) 0x3ff, MIN_VALUE));
-        assertTrue(Half.lessEquals(NEGATIVE_INFINITY, NEGATIVE_INFINITY));
-        assertTrue(Half.lessEquals(POSITIVE_INFINITY, POSITIVE_INFINITY));
-        assertTrue(Half.lessEquals(toHalf(12.12356f), toHalf(12.12356f)));
-        assertTrue(Half.lessEquals(toHalf(-12.12356f), toHalf(-12.12356f)));
+        assertTrue(Half.greaterEquals((short) 0x3ff, MIN_VALUE));
+        assertTrue(Half.greaterEquals(NEGATIVE_INFINITY, NEGATIVE_INFINITY));
+        assertTrue(Half.greaterEquals(POSITIVE_INFINITY, POSITIVE_INFINITY));
+        assertTrue(Half.greaterEquals(toHalf(12.12356f), toHalf(12.12356f)));
+        assertTrue(Half.greaterEquals(toHalf(-12.12356f), toHalf(-12.12356f)));
     }
 
     @Test