tree d7bfb60b04b72f621d6239a1bf50cf38c3912cd8
parent 4d9dac1e142d4716f0d7bdb7a9f17bc2fd282f18
author Svet Ganov <svetoslavganov@google.com> 1569299633 -0700
committer android-build-team Robot <android-build-team-robot@google.com> 1572304913 +0000

Update PermissionChecker usages to avoid unnecessary attribution.

Merge Conflict Resolution for qt-release branch.

We had accidental usages of the PermissionChecker for cases where no
private data was provided to the app but the checkPermission API on
the latter also did blame data access on the app. The PermissionChecker
was designed to handle IPC calls and not for generic API checks.

To avoid future accidental incorrect PermissionChecker usages this
change renames the existing APIs of the latter to clearly indicate
that they should be used for data delivery and also adds sibling
methods for doing the same permission checks for preflight purposes.
Also the documentation is improved to furhter assist developers.

In addition, this change fixes accidental permission checker usages
that blame when they should not by using the new preflight flavor
of the permission check APIs.

Test:
    atest com.android.settingslib.location.RecentLocationAppsTest
    atest CtsPermissionTestCases
    added: LocationAccessCheckTest#notificationOnlyForAccessesSinceFeatureWasEnabled
    added: LocationAccessCheckTest#noNotificationIfFeatureDisabled
    added: LocationAccessCheckTest#noNotificationIfBlamerNotSystemOrLocationProvider
    added: LocationAccessCheckTest#testOpeningLocationSettingsDoesNotTriggerAccess

bug:141028068
Merged-in: I941dfbca9cb5560bd0facfa4671c04c89965919e
Change-Id: I941dfbca9cb5560bd0facfa4671c04c89965919e
(cherry picked from commit 7c85f8eb006661e21df4e37eb356f34141dc8eb2)