commit a3aa3eb2482e33f4b38ad57b3fd89a80147ff6e2
author Sascha Haeberling <haeberling@google.com> Thu Oct 23 19:05:56 2014 -0700
committer Sascha Haeberling <haeberling@google.com> Fri Oct 24 14:46:08 2014 -0700
tree d1b9437202e7da56c5d38ea3ee25a44ea9f6e006
parent e350522c5c44c411d5a69a956c2ce76b97b2e52d

[CtsVerifier] Make sure to set camera parameters before measuring FOV.

  Bug: 18110354

Change-Id: Ida3868640c85c454cf74cc2781fbf1dc29f527c5

apps/CtsVerifier/src/com/android/cts/verifier/camera/fov/PhotoCaptureActivity.java

diff --git a/apps/CtsVerifier/src/com/android/cts/verifier/camera/fov/PhotoCaptureActivity.java b/apps/CtsVerifier/src/com/android/cts/verifier/camera/fov/PhotoCaptureActivity.java
index 178a811..eea1b76 100644
--- a/apps/CtsVerifier/src/com/android/cts/verifier/camera/fov/PhotoCaptureActivity.java
+++ b/apps/CtsVerifier/src/com/android/cts/verifier/camera/fov/PhotoCaptureActivity.java
@@ -171,7 +171,7 @@
                     mReportedFovPrePictureTaken = mCamera.getParameters().getHorizontalViewAngle();
 
                     mResolutionSpinnerIndex = position;
-                    initializeCamera();
+                    startPreview();
                 }
             }
 
@@ -395,6 +395,10 @@
     }
 
     private void initializeCamera() {
+        initializeCamera(true);
+    }
+
+    private void initializeCamera(boolean startPreviewAfterInit) {
         if (mCamera == null || mSurfaceHolder.getSurface() == null) {
             return;
         }
@@ -417,7 +421,10 @@
             mCamera.setParameters(params);
             mCameraInitialized = true;
         }
-        startPreview();
+
+        if (startPreviewAfterInit) {
+          startPreview();
+        }
     }
 
     private void startPreview() {
@@ -428,7 +435,7 @@
         }
     }
 
-    private void switchToCamera(SelectableResolution resolution, boolean initializeCamera) {
+    private void switchToCamera(SelectableResolution resolution, boolean startPreview) {
         if (mCamera != null) {
             mCamera.stopPreview();
             mCamera.release();
@@ -437,9 +444,7 @@
         mSelectedResolution = resolution;
         mCamera = Camera.open(mSelectedResolution.cameraId);
 
-        if (initializeCamera){
-          initializeCamera();
-        }
+        initializeCamera(startPreview);
     }
 
     /**