Adjust device info constants for consistency.
Attempt to use the same attribute values in all three places they are defined.
Remove attributes not being referenced in current XML.
Change-Id: I3046a16b50e2c3ca3fb273d789007fe7fc294870
diff --git a/tools/device-setup/TestDeviceSetup/src/android/tests/getinfo/DeviceInfoInstrument.java b/tools/device-setup/TestDeviceSetup/src/android/tests/getinfo/DeviceInfoInstrument.java
index 5a2fd6a..f702898 100644
--- a/tools/device-setup/TestDeviceSetup/src/android/tests/getinfo/DeviceInfoInstrument.java
+++ b/tools/device-setup/TestDeviceSetup/src/android/tests/getinfo/DeviceInfoInstrument.java
@@ -40,7 +40,9 @@
private static final String TAG = "DeviceInfoInstrument";
- private static final String OPEN_GL_ES_VERSION = "opengles_version";
+ // constants for device info attributes to be sent as instrumentation keys
+ // these values should correspond to attributes defined in cts_result.xsd
+ private static final String OPEN_GL_ES_VERSION = "openGlEsVersion";
private static final String PROCESSES = "processes";
private static final String FEATURES = "features";
private static final String PHONE_NUMBER = "phoneNumber";
@@ -50,26 +52,23 @@
private static final String NETWORK = "network";
public static final String KEYPAD = "keypad";
public static final String NAVIGATION = "navigation";
- public static final String TOUCH_SCREEN = "touch_screen";
- private static final String SCREEN_Y_DENSITY = "screen_Y_density";
- private static final String SCREEN_X_DENSITY = "screen_X_density";
- private static final String SCREEN_DENSITY = "screen_density";
+ public static final String TOUCH_SCREEN = "touch";
+ private static final String SCREEN_Y_DENSITY = "Ydpi";
+ private static final String SCREEN_X_DENSITY = "Xdpi";
private static final String SCREEN_HEIGHT = "screen_height";
private static final String SCREEN_WIDTH = "screen_width";
- private static final String VERSION_SDK = "version_sdk";
- private static final String VERSION_RELEASE = "version_release";
- private static final String VERSION_INCREMENTAL = "version_incremental";
+ private static final String VERSION_SDK = "androidPlatformVersion";
+ private static final String VERSION_RELEASE = "buildVersion";
private static final String BUILD_ABI = "build_abi";
private static final String BUILD_ABI2 = "build_abi2";
private static final String BUILD_FINGERPRINT = "build_fingerprint";
- private static final String BUILD_TAGS = "build_tags";
private static final String BUILD_TYPE = "build_type";
private static final String BUILD_MODEL = "build_model";
private static final String BUILD_BRAND = "build_brand";
private static final String BUILD_BOARD = "build_board";
private static final String BUILD_DEVICE = "build_device";
- private static final String PRODUCT_NAME = "product_name";
- private static final String BUILD_ID = "build_id";
+ private static final String PRODUCT_NAME = "buildName";
+ private static final String BUILD_ID = "buildID";
private static Bundle mResults = new Bundle();
public DeviceInfoInstrument() {
@@ -91,12 +90,10 @@
addResult(BUILD_BRAND, Build.BRAND);
addResult(BUILD_MODEL, Build.MODEL);
addResult(BUILD_TYPE, Build.TYPE);
- addResult(BUILD_TAGS, Build.TAGS);
addResult(BUILD_FINGERPRINT, Build.FINGERPRINT);
addResult(BUILD_ABI, Build.CPU_ABI);
addResult(BUILD_ABI2, Build.CPU_ABI2);
- addResult(VERSION_INCREMENTAL, Build.VERSION.INCREMENTAL);
addResult(VERSION_RELEASE, Build.VERSION.RELEASE);
addResult(VERSION_SDK, Build.VERSION.SDK);
@@ -107,7 +104,6 @@
d.getMetrics(metrics);
addResult(SCREEN_WIDTH, metrics.widthPixels);
addResult(SCREEN_HEIGHT, metrics.heightPixels);
- addResult(SCREEN_DENSITY, metrics.density);
addResult(SCREEN_X_DENSITY, metrics.xdpi);
addResult(SCREEN_Y_DENSITY, metrics.ydpi);
diff --git a/tools/host/src/com/android/cts/TestDevice.java b/tools/host/src/com/android/cts/TestDevice.java
index c96a4eb..ad71335 100644
--- a/tools/host/src/com/android/cts/TestDevice.java
+++ b/tools/host/src/com/android/cts/TestDevice.java
@@ -403,9 +403,11 @@
* Store the build information of a device
*/
public static final class DeviceParameterCollector{
- public static final String PRODUCT_NAME = "product_name";
- public static final String BUILD_VERSION = "version_release";
- public static final String BUILD_ID = "build_id";
+ // the device info keys expected to be sent from device info instrumentation
+ // these constants should match exactly with those defined in DeviceInfoInstrument.jaa
+ public static final String PRODUCT_NAME = "buildName";
+ public static final String BUILD_VERSION = "buildVersion";
+ public static final String BUILD_ID = "buildID";
public static final String BUILD_FINGERPRINT = "build_fingerprint";
public static final String BUILD_TAGS = "build_tags";
public static final String BUILD_TYPE = "build_type";
@@ -417,13 +419,12 @@
public static final String BUILD_ABI2 = "build_abi2";
public static final String SCREEN_HEIGHT = "screen_height";
public static final String SCREEN_WIDTH = "screen_width";
- public static final String SCREEN_DENSITY = "screen_density";
public static final String SERIAL_NUMBER = "serialNumber";
- public static final String VERSION_SDK = "version_sdk";
+ public static final String VERSION_SDK = "androidPlatformVersion";
public static final String LOCALES = "locales";
- public static final String SCREEN_Y_DENSITY = "screen_Y_density";
- public static final String SCREEN_X_DENSITY = "screen_X_density";
- public static final String TOUCH_SCREEN = "touch_screen";
+ public static final String SCREEN_Y_DENSITY = "Ydpi";
+ public static final String SCREEN_X_DENSITY = "Xdpi";
+ public static final String TOUCH_SCREEN = "touch";
public static final String NAVIGATION = "navigation";
public static final String KEYPAD = "keypad";
public static final String NETWORK = "network";
@@ -432,7 +433,7 @@
public static final String PHONE_NUMBER = "phoneNumber";
public static final String FEATURES = "features";
public static final String PROCESSES = "processes";
- public static final String OPEN_GL_ES_VERSION = "opengles_version";
+ public static final String OPEN_GL_ES_VERSION = "openGlEsVersion";
private HashMap<String, String> mInfoMap;
