Extract out device info collection constants.
Previously, there was duplicate copies of device info constants in device-side
code, and in the cts harness host code.
This change creates a library shared between the device and host side.
Change-Id: I6539f07f50a3a8c657209ca40e1f0d11aed96154
diff --git a/tools/device-setup/TestDeviceSetup/Android.mk b/tools/device-setup/TestDeviceSetup/Android.mk
index 3704be5..413f50b 100644
--- a/tools/device-setup/TestDeviceSetup/Android.mk
+++ b/tools/device-setup/TestDeviceSetup/Android.mk
@@ -30,3 +30,14 @@
include $(BUILD_PACKAGE)
+# ======================================================
+# also build a static host library for the device info constants
+include $(CLEAR_VARS)
+
+LOCAL_SRC_FILES := src/android/tests/getinfo/DeviceInfoConstants.java
+
+LOCAL_MODULE_TAGS := optional
+
+LOCAL_MODULE := ctsdeviceinfolib
+
+include $(BUILD_HOST_JAVA_LIBRARY)
diff --git a/tools/device-setup/TestDeviceSetup/src/android/tests/getinfo/DeviceInfoActivity.java b/tools/device-setup/TestDeviceSetup/src/android/tests/getinfo/DeviceInfoActivity.java
index e6c0e14..bcba1cb 100644
--- a/tools/device-setup/TestDeviceSetup/src/android/tests/getinfo/DeviceInfoActivity.java
+++ b/tools/device-setup/TestDeviceSetup/src/android/tests/getinfo/DeviceInfoActivity.java
@@ -64,7 +64,7 @@
touchScreen = "finger";
}
if (touchScreen != null) {
- DeviceInfoInstrument.addResult(DeviceInfoInstrument.TOUCH_SCREEN,
+ DeviceInfoInstrument.addResult(DeviceInfoConstants.TOUCH_SCREEN,
touchScreen);
}
@@ -82,7 +82,7 @@
}
if (navigation != null) {
- DeviceInfoInstrument.addResult(DeviceInfoInstrument.NAVIGATION,
+ DeviceInfoInstrument.addResult(DeviceInfoConstants.NAVIGATION,
navigation);
}
@@ -97,7 +97,7 @@
keypad = "12key";
}
if (keypad != null) {
- DeviceInfoInstrument.addResult(DeviceInfoInstrument.KEYPAD, keypad);
+ DeviceInfoInstrument.addResult(DeviceInfoConstants.KEYPAD, keypad);
}
String[] locales = getAssets().getLocales();
@@ -110,7 +110,7 @@
}
localeList.append(";");
}
- DeviceInfoInstrument.addResult(DeviceInfoInstrument.LOCALES,
+ DeviceInfoInstrument.addResult(DeviceInfoConstants.LOCALES,
localeList.toString());
synchronized (sync) {
diff --git a/tools/device-setup/TestDeviceSetup/src/android/tests/getinfo/DeviceInfoConstants.java b/tools/device-setup/TestDeviceSetup/src/android/tests/getinfo/DeviceInfoConstants.java
new file mode 100644
index 0000000..d181a9b
--- /dev/null
+++ b/tools/device-setup/TestDeviceSetup/src/android/tests/getinfo/DeviceInfoConstants.java
@@ -0,0 +1,60 @@
+/*
+ * Copyright (C) 2011 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package android.tests.getinfo;
+
+/**
+ * Constants for device info attributes to be sent as instrumentation keys.
+ * <p/>
+ * These values should correspond to attributes defined in cts_result.xsd.
+ */
+public interface DeviceInfoConstants {
+
+ public static final String OPEN_GL_ES_VERSION = "openGlEsVersion";
+ public static final String PROCESSES = "processes";
+ public static final String FEATURES = "features";
+ public static final String PHONE_NUMBER = "phoneNumber";
+ public static final String LOCALES = "locales";
+ public static final String IMSI = "imsi";
+ public static final String IMEI = "imei";
+ public static final String NETWORK = "network";
+ public static final String KEYPAD = "keypad";
+ public static final String NAVIGATION = "navigation";
+ public static final String TOUCH_SCREEN = "touch";
+ public static final String SCREEN_Y_DENSITY = "Ydpi";
+ public static final String SCREEN_X_DENSITY = "Xdpi";
+ public static final String SCREEN_SIZE = "screen_size";
+ public static final String SCREEN_DENSITY_BUCKET = "screen_density_bucket";
+ public static final String SCREEN_DENSITY = "screen_density";
+ public static final String SCREEN_HEIGHT = "screen_height";
+ public static final String SCREEN_WIDTH = "screen_width";
+ public static final String VERSION_SDK = "androidPlatformVersion";
+ public static final String VERSION_RELEASE = "buildVersion";
+ public static final String BUILD_ABI = "build_abi";
+ public static final String BUILD_ABI2 = "build_abi2";
+ public static final String BUILD_FINGERPRINT = "build_fingerprint";
+ public static final String BUILD_TYPE = "build_type";
+ public static final String BUILD_MODEL = "build_model";
+ public static final String BUILD_BRAND = "build_brand";
+ public static final String BUILD_MANUFACTURER = "build_manufacturer";
+ public static final String BUILD_BOARD = "build_board";
+ public static final String BUILD_DEVICE = "build_device";
+ public static final String PRODUCT_NAME = "buildName";
+ public static final String BUILD_ID = "buildID";
+ public static final String BUILD_VERSION = "buildVersion";
+ public static final String BUILD_TAGS = "build_tags";
+ public static final String SERIAL_NUMBER = "serialNumber";
+}
diff --git a/tools/device-setup/TestDeviceSetup/src/android/tests/getinfo/DeviceInfoInstrument.java b/tools/device-setup/TestDeviceSetup/src/android/tests/getinfo/DeviceInfoInstrument.java
index 31168fd..1299aae 100644
--- a/tools/device-setup/TestDeviceSetup/src/android/tests/getinfo/DeviceInfoInstrument.java
+++ b/tools/device-setup/TestDeviceSetup/src/android/tests/getinfo/DeviceInfoInstrument.java
@@ -37,43 +37,10 @@
import java.util.List;
import java.util.Set;
-public class DeviceInfoInstrument extends Instrumentation {
+public class DeviceInfoInstrument extends Instrumentation implements DeviceInfoConstants {
private static final String TAG = "DeviceInfoInstrument";
- // constants for device info attributes to be sent as instrumentation keys
- // these values should correspond to attributes defined in cts_result.xsd
- private static final String OPEN_GL_ES_VERSION = "openGlEsVersion";
- private static final String PROCESSES = "processes";
- private static final String FEATURES = "features";
- private static final String PHONE_NUMBER = "phoneNumber";
- public static final String LOCALES = "locales";
- private static final String IMSI = "imsi";
- private static final String IMEI = "imei";
- private static final String NETWORK = "network";
- public static final String KEYPAD = "keypad";
- public static final String NAVIGATION = "navigation";
- public static final String TOUCH_SCREEN = "touch";
- private static final String SCREEN_Y_DENSITY = "Ydpi";
- private static final String SCREEN_X_DENSITY = "Xdpi";
- private static final String SCREEN_SIZE = "screen_size";
- private static final String SCREEN_DENSITY_BUCKET = "screen_density_bucket";
- private static final String SCREEN_DENSITY = "screen_density";
- private static final String SCREEN_HEIGHT = "screen_height";
- private static final String SCREEN_WIDTH = "screen_width";
- private static final String VERSION_SDK = "androidPlatformVersion";
- private static final String VERSION_RELEASE = "buildVersion";
- private static final String BUILD_ABI = "build_abi";
- private static final String BUILD_ABI2 = "build_abi2";
- private static final String BUILD_FINGERPRINT = "build_fingerprint";
- private static final String BUILD_TYPE = "build_type";
- private static final String BUILD_MODEL = "build_model";
- private static final String BUILD_BRAND = "build_brand";
- private static final String BUILD_MANUFACTURER = "build_manufacturer";
- private static final String BUILD_BOARD = "build_board";
- private static final String BUILD_DEVICE = "build_device";
- private static final String PRODUCT_NAME = "buildName";
- private static final String BUILD_ID = "buildID";
private static Bundle mResults = new Bundle();
public DeviceInfoInstrument() {
diff --git a/tools/host/src/Android.mk b/tools/host/src/Android.mk
index 5ad3998..d9195eb 100644
--- a/tools/host/src/Android.mk
+++ b/tools/host/src/Android.mk
@@ -23,6 +23,8 @@
LOCAL_JAVA_LIBRARIES := \
ddmlib-prebuilt junit hosttestlib CtsTestAnnotationsHostLib
+LOCAL_STATIC_JAVA_LIBRARIES := ctsdeviceinfolib
+
LOCAL_MODULE := cts
include $(BUILD_HOST_JAVA_LIBRARY)
diff --git a/tools/host/src/com/android/cts/TestDevice.java b/tools/host/src/com/android/cts/TestDevice.java
index 88bcd68..19f754a 100644
--- a/tools/host/src/com/android/cts/TestDevice.java
+++ b/tools/host/src/com/android/cts/TestDevice.java
@@ -32,6 +32,8 @@
import com.android.ddmlib.log.LogReceiver;
import com.android.ddmlib.log.LogReceiver.ILogListener;
+import android.tests.getinfo.DeviceInfoConstants;
+
import java.io.BufferedReader;
import java.io.FileNotFoundException;
import java.io.IOException;
@@ -400,42 +402,7 @@
/**
* Store the build information of a device
*/
- public static final class DeviceParameterCollector{
- // the device info keys expected to be sent from device info instrumentation
- // these constants should match exactly with those defined in DeviceInfoInstrument.jaa
- public static final String PRODUCT_NAME = "buildName";
- public static final String BUILD_VERSION = "buildVersion";
- public static final String BUILD_ID = "buildID";
- public static final String BUILD_FINGERPRINT = "build_fingerprint";
- public static final String BUILD_TAGS = "build_tags";
- public static final String BUILD_TYPE = "build_type";
- public static final String BUILD_MANUFACTURER = "build_manufacturer";
- public static final String BUILD_MODEL = "build_model";
- public static final String BUILD_BRAND = "build_brand";
- public static final String BUILD_BOARD = "build_board";
- public static final String BUILD_DEVICE = "build_device";
- public static final String BUILD_ABI = "build_abi";
- public static final String BUILD_ABI2 = "build_abi2";
- public static final String SCREEN_SIZE = "screen_size";
- public static final String SCREEN_HEIGHT = "screen_height";
- public static final String SCREEN_WIDTH = "screen_width";
- public static final String SCREEN_DENSITY = "screen_density";
- public static final String SCREEN_DENSITY_BUCKET = "screen_density_bucket";
- public static final String SERIAL_NUMBER = "serialNumber";
- public static final String VERSION_SDK = "androidPlatformVersion";
- public static final String LOCALES = "locales";
- public static final String SCREEN_Y_DENSITY = "Ydpi";
- public static final String SCREEN_X_DENSITY = "Xdpi";
- public static final String TOUCH_SCREEN = "touch";
- public static final String NAVIGATION = "navigation";
- public static final String KEYPAD = "keypad";
- public static final String NETWORK = "network";
- public static final String IMEI = "imei";
- public static final String IMSI = "imsi";
- public static final String PHONE_NUMBER = "phoneNumber";
- public static final String FEATURES = "features";
- public static final String PROCESSES = "processes";
- public static final String OPEN_GL_ES_VERSION = "openGlEsVersion";
+ public static final class DeviceParameterCollector implements DeviceInfoConstants {
private HashMap<String, String> mInfoMap;