tree 965a28d46847e42e68cbee95fb16c12481cb706e
parent 51808c4208b17d3db94bf694ecc12719f35aa21f
author Matthias Maennich <maennich@google.com> 1630625181 +0100
committer lberki <lberki@users.noreply.github.com> 1630933795 +0200

CommandEvaluator: reduce needless allocations and clarify interface

When command vectors are populated by the caller as vector<Command*> and
passed as an input/output parameter via pointer. This interface is
problematic as the contract is not well defined. Clarify that by always
producing the vector within CommandEvaluator::Eval() and return it by
value. Further, the commands are usually only read and never ownership
is transferred. Hence let the vector manage the allocations and don't
bother about that any longer by passing vector<Command> instead.

Signed-off-by: Matthias Maennich <maennich@google.com>