Google Git
Sign in
android / platform / build / blueprint / e535c97
commite535c97cc90096a84861fc8743f6a9515a22b68e[log] [tgz]
authorColin Cross <ccross@android.com>Wed Jan 20 10:57:58 2021 -0800
committerColin Cross <ccross@android.com>Wed Jan 20 11:01:41 2021 -0800
tree3a47c0a4681fc7edb3b9291d062a73dca6c3bd5f
parent94a5c0169390ee29fe3ab8f8668c7a73e99d944e [diff]
Remove redundant stat/lstat calls from glob

Glob was calling IsSymlink and IsDir on each visited directory entry,
which resulted in an lstat and then a stat call on each.

Instead, use lstat when not following symlinks and use stat when
following symlinks, then use the result to check if the entry is a
directory.

Test: glob_test.go
Change-Id: I83d769e2de64ce8221e952e5204d365aeaf47687
2 files changed
tree: 3a47c0a4681fc7edb3b9291d062a73dca6c3bd5f
  1. .github/
  2. bootstrap/
  3. bpfmt/
  4. bpmodify/
  5. deptools/
  6. gotestmain/
  7. gotestrunner/
  8. loadplugins/
  9. microfactory/
  10. parser/
  11. pathtools/
  12. proptools/
  13. tests/
  14. .gitignore
  15. .gofmt.sh
  16. blueprint.bash
  17. blueprint_impl.bash
  18. Blueprints
  19. bootstrap.bash
  20. CODEOWNERS
  21. context.go
  22. context_test.go
  23. CONTRIBUTING.md
  24. doc.go
  25. glob.go
  26. glob_test.go
  27. go.mod
  28. LICENSE
  29. live_tracker.go
  30. mangle.go
  31. module_ctx.go
  32. module_ctx_test.go
  33. name_interface.go
  34. ninja_defs.go
  35. ninja_strings.go
  36. ninja_strings_test.go
  37. ninja_writer.go
  38. ninja_writer_test.go
  39. package_ctx.go
  40. provider.go
  41. provider_test.go
  42. README.md
  43. scope.go
  44. singleton_ctx.go
  45. splice_modules_test.go
  46. visit_test.go
README.md

Blueprint Build System

build

Blueprint is a meta-build system that reads in Blueprints files that describe modules that need to be built, and produces a Ninja manifest describing the commands that need to be run and their dependencies. Where most build systems use built-in rules or a domain-specific language to describe the logic for converting module descriptions to build rules, Blueprint delegates this to per-project build logic written in Go. For large, heterogenous projects this allows the inherent complexity of the build logic to be maintained in a high-level language, while still allowing simple changes to individual modules by modifying easy to understand Blueprints files.