envsetup: Optimize vendorsetup.sh scanning

Follow up to: ag/38202271

Previously, source_vendorsetup captured the output of `find` into a variable
and iterated over it using a standard `for` loop. This approach is unsafe
because the shell splits the variable expansion on whitespace, causing
errors if any directory or filename in the tree contains spaces.
I missed this issue because my checkout did not contain such files, and I assumed this won't happen. But clearly I was wrong, because some users immediately began reporting problems.

This change switches the iteration logic to use a `while IFS= read -r`
loop with process substitution. This ensures that paths with spaces are
handled correctly and avoids potential issues with variable size limits
if the list of vendor setup files is large.
This is a good change regardless because it's safer and more technically correct.

Fixes: 481832043
Change-Id: Iac3b1e36bd775267333c23ad5c294f8df41331ae
1 file changed
tree: f8e4487c411f6fdc8aca2cf4fd3f8d60ec645b7e
  1. backported_fixes/
  2. ci/
  3. common/
  4. core/
  5. packaging/
  6. target/
  7. teams/
  8. tests/
  9. tools/
  10. .gitignore
  11. Android.bp
  12. banchanHelp.sh
  13. buildspec.mk.default
  14. Changes.md
  15. CleanSpec.mk
  16. Deprecation.md
  17. envsetup.sh
  18. help.sh
  19. navbar.md
  20. OWNERS
  21. PREUPLOAD.cfg
  22. rbesetup.sh
  23. README.md
  24. shell_utils.sh
  25. tapasHelp.sh
  26. Usage.txt
README.md

Android Make Build System

This is the Makefile-based portion of the Android Build System.

For documentation on how to run a build, see Usage.txt

For a list of behavioral changes useful for Android.mk writers see Changes.md

For an outdated reference on Android.mk files, see build-system.html. Our Android.mk files look similar, but are entirely different from the Android.mk files used by the NDK build system. When searching for documentation elsewhere, ensure that it is for the platform build system -- most are not.

This Makefile-based system is in the process of being replaced with Soong, a new build system written in Go. During the transition, all of these makefiles are read by Kati, and generate a ninja file instead of being executed directly. That's combined with a ninja file read by Soong so that the build graph of the two systems can be combined and run as one.