commit e6e60065ff093ff8c859ab146cf543531cb1967c
author Elliott Hughes <enh@google.com> Thu Jan 10 16:01:59 2013 -0800
committer Elliott Hughes <enh@google.com> Thu Jan 10 16:01:59 2013 -0800
tree 41de4f1d0cf5cec9fa72c4ad6d0fed5bf1b00329
parent 0d3700d957debe841c385f66a8026ca8b3755815

glibc 2.15 treats errno as signed in strerror(3).

And the only reason I hadn't done that in bionic is because I wanted to behave
the same as glibc.

Change-Id: I2cf1bf0aac82a748cd6305a2cabbac0790058570

libc/bionic/strerror_r.cpp

diff --git a/libc/bionic/strerror_r.cpp b/libc/bionic/strerror_r.cpp
index e6a3975..646cc52 100644
--- a/libc/bionic/strerror_r.cpp
+++ b/libc/bionic/strerror_r.cpp
@@ -49,7 +49,7 @@
   if (error_name != NULL) {
     length = snprintf(buf, buf_len, "%s", error_name);
   } else {
-    length = snprintf(buf, buf_len, "Unknown error %u", error_number);
+    length = snprintf(buf, buf_len, "Unknown error %d", error_number);
   }
   if (length >= buf_len) {
     errno = ERANGE;

tests/string_test.cpp

diff --git a/tests/string_test.cpp b/tests/string_test.cpp
index 71998d8..d55771c 100644
--- a/tests/string_test.cpp
+++ b/tests/string_test.cpp
@@ -39,7 +39,7 @@
   ASSERT_STREQ("Operation not permitted", strerror(1));
 
   // Invalid.
-  ASSERT_STREQ("Unknown error 4294967295", strerror(-1));
+  ASSERT_STREQ("Unknown error -1", strerror(-1));
   ASSERT_STREQ("Unknown error 1234", strerror(1234));
 }