|author||Elliott Hughes <firstname.lastname@example.org>||Mon Nov 14 13:56:32 2016 -0800|
|committer||gitbuildkicker <email@example.com>||Mon Dec 19 14:39:38 2016 -0800|
Check for bad packets in getaddrinfo.c's getanswer. The near duplicate in gethnamaddr.c was already doing so (this fix is basically copy and pasted from there, but with both copies modified to avoid skirting undefined behavior). Bug: http://b/32322088 Test: browser still works Change-Id: Ied6662be567fb1bddc7ceb138cae1da77fb57976 (cherry picked from commit 27a4459d945e34fabd7166791a5b862ccea83f23) (cherry picked from commit 418fe1eb1aeefc2268a40c5cec0ceb62672fa026)
The C library. Stuff like
The math library. Traditionally Unix systems kept stuff like
cos(3) in a separate library to save space in the days before shared libraries.
The dynamic linker interface library. This is actually just a bunch of stubs that the dynamic linker replaces with pointers to its own implementation at runtime. This is where stuff like
The C++ ABI support functions. The C++ compiler doesn't know how to implement thread-safe static initialization and the like, so it just calls functions that are supplied by the system. Stuff like
__cxa_pure_virtual live here.
The dynamic linker. When you run a dynamically-linked executable, its ELF file has a
DT_INTERP entry that says “use the following program to start me”. On Android, that‘s either
linker64 (depending on whether it’s a 32-bit or 64-bit executable). It's responsible for loading the ELF executable into memory and resolving references to symbols (so that when your code tries to jump to
fopen(3), say, it lands in the right place).
tests/ directory contains unit tests. Roughly arranged as one file per publicly-exported header file.
benchmarks/ directory contains benchmarks.
Adding a system call usually involves:
As mentioned above, this is currently a two-step process:
This is fully automated (and these days handled by the libcore team, because they own icu, and that needs to be updated in sync with bionic):
If you make a change that is likely to have a wide effect on the tree (such as a libc header change), you should run
make checkbuild. A regular
make will not build the entire tree; just the minimum number of projects that are required for the device. Tests, additional developer tools, and various other modules will not be built. Note that
make checkbuild will not be complete either, as
make tests covers a few additional modules, but generally speaking
make checkbuild is enough.
The tests are all built from the tests/ directory.
$ mma $ adb remount $ adb sync $ adb shell /data/nativetest/bionic-unit-tests/bionic-unit-tests32 $ adb shell \ /data/nativetest/bionic-unit-tests-static/bionic-unit-tests-static32 # Only for 64-bit targets $ adb shell /data/nativetest64/bionic-unit-tests/bionic-unit-tests64 $ adb shell \ /data/nativetest64/bionic-unit-tests-static/bionic-unit-tests-static64
The host tests require that you have
lunched either an x86 or x86_64 target.
$ mma $ mm bionic-unit-tests-run-on-host32 $ mm bionic-unit-tests-run-on-host64 # For 64-bit *targets* only.
As a way to check that our tests do in fact test the correct behavior (and not just the behavior we think is correct), it is possible to run the tests against the host's glibc. The executables are already in your path.
$ mma $ bionic-unit-tests-glibc32 $ bionic-unit-tests-glibc64
For either host or target coverage, you must first:
$ export NATIVE_COVERAGE=true
$ mma $ adb sync $ adb shell \ GCOV_PREFIX=/data/local/tmp/gcov \ GCOV_PREFIX_STRIP=`echo $ANDROID_BUILD_TOP | grep -o / | wc -l` \ /data/nativetest/bionic-unit-tests/bionic-unit-tests32 $ acov
acov will pull all coverage information from the device, push it to the right directories, run
lcov, and open the coverage report in your browser.
First, build and run the host tests as usual (see above).
$ croot $ lcov -c -d $ANDROID_PRODUCT_OUT -o coverage.info $ genhtml -o covreport coverage.info # or lcov --list coverage.info
The coverage report is now available at
Bionic's test runner will run each test in its own process by default to prevent tests failures from impacting other tests. This also has the added benefit of running them in parallel, so they are much faster.
However, this also makes it difficult to run the tests under GDB. To prevent each test from being forked, run the tests with the flag
This probably belongs in the NDK documentation rather than here, but these are the known ABI bugs in the 32-bit ABI:
time_t is 32-bit. http://b/5819737. In the 64-bit ABI, time_t is 64-bit.
off_t is 32-bit. There is
off64_t, and in newer releases there is almost-complete support for
_FILE_OFFSET_BITS. Unfortunately our stdio implementation uses 32-bit offsets and -- worse -- function pointers to functions that use 32-bit offsets, so there's no good way to implement the last few pieces http://b/24807045. In the 64-bit ABI, off_t is off64_t.
sigset_t is too small on ARM and x86 (but correct on MIPS), so support for real-time signals is broken. http://b/5828899 In the 64-bit ABI,
sigset_t is the correct size for every architecture.