commit | 62d84b19359a8ddd3df5b6293d1b05ef5281f532 | [log] [tgz] |
---|---|---|
author | Christopher Ferris <cferris@google.com> | Mon Oct 20 19:09:19 2014 -0700 |
committer | Christopher Ferris <cferris@google.com> | Wed Oct 22 13:20:39 2014 -0700 |
tree | b614f0c9c9671eb6beaec448a7d22dc1ad44e298 | |
parent | 098cf45f4e853f3c85c14af0e475bfae0839f027 [diff] |
Fix race condition in timer disarm/delete. When setting a repeat timer using the SIGEV_THREAD mechanism, it's possible that the callback can be called after the timer is disarmed or deleted. This happens because the kernel can generate signals that the timer thread will continue to handle even after the timer is supposed to be off. Add two new tests to verify that disarming/deleting doesn't continue to call the callback. Modify the repeat test to finish more quickly than before. Refactor the Counter implementation a bit. Bug: 18039727 (cherry pick from commit 0724132c3263145f2a667f453a199d313a5b3d9f) Change-Id: I135726ea4038a47920a6c511708813b1a9996c42
The C library. Stuff like fopen(3)
and kill(2)
.
The math library. Traditionally Unix systems kept stuff like sin(3)
and cos(3)
in a separate library to save space in the days before shared libraries.
The dynamic linker interface library. This is actually just a bunch of stubs that the dynamic linker replaces with pointers to its own implementation at runtime. This is where stuff like dlopen(3)
lives.
The C++ ABI support functions. The C++ compiler doesn't know how to implement thread-safe static initialization and the like, so it just calls functions that are supplied by the system. Stuff like __cxa_guard_acquire
and __cxa_pure_virtual
live here.
The dynamic linker. When you run a dynamically-linked executable, its ELF file has a DT_INTERP
entry that says “use the following program to start me”. On Android, that‘s either linker
or linker64
(depending on whether it’s a 32-bit or 64-bit executable). It's responsible for loading the ELF executable into memory and resolving references to symbols (so that when your code tries to jump to fopen(3)
, say, it lands in the right place).
The tests/
directory contains unit tests. Roughly arranged as one file per publicly-exported header file.
The benchmarks/
directory contains benchmarks.
Adding a system call usually involves:
As mentioned above, this is currently a two-step process:
This is fully automated:
The tests are all built from the tests/ directory.
$ mma $ adb sync $ adb shell /data/nativetest/bionic-unit-tests/bionic-unit-tests32 $ adb shell \ /data/nativetest/bionic-unit-tests-static/bionic-unit-tests-static32 # Only for 64-bit targets $ adb shell /data/nativetest/bionic-unit-tests/bionic-unit-tests64 $ adb shell \ /data/nativetest/bionic-unit-tests-static/bionic-unit-tests-static64
The host tests require that you have lunch
ed either an x86 or x86_64 target.
$ mma # 64-bit tests for 64-bit targets, 32-bit otherwise. $ mm bionic-unit-tests-run-on-host # Only exists for 64-bit targets. $ mm bionic-unit-tests-run-on-host32
As a way to check that our tests do in fact test the correct behavior (and not just the behavior we think is correct), it is possible to run the tests against the host's glibc.
$ mma $ bionic-unit-tests-glibc32 # already in your path $ bionic-unit-tests-glibc64
For either host or target coverage, you must first:
$ export NATIVE_COVERAGE=true
bionic_coverage=true
in libc/Android.mk
and libm/Android.mk
.$ mma $ adb sync $ adb shell \ GCOV_PREFIX=/data/local/tmp/gcov \ GCOV_PREFIX_STRIP=`echo $ANDROID_BUILD_TOP | grep -o / | wc -l` \ /data/nativetest/bionic-unit-tests/bionic-unit-tests32 $ acov
acov
will pull all coverage information from the device, push it to the right directories, run lcov
, and open the coverage report in your browser.
First, build and run the host tests as usual (see above).
$ croot $ lcov -c -d $ANDROID_PRODUCT_OUT -o coverage.info $ genhtml -o covreport coverage.info # or lcov --list coverage.info
The coverage report is now available at covreport/index.html
.