commit ccf7c8a68972f3b7bfa38af0c6b792f712f83765
author Hiroshi Yamauchi <yamauchi@google.com> Fri Jul 29 17:41:01 2016 +0000
committer Hiroshi Yamauchi <yamauchi@google.com> Fri Jul 29 17:41:01 2016 +0000
tree 3132e2e1e5b1f1af558652d9b39eeb6c994ec256
parent 8256da35feac0ba7589fcd4b692a4b9a936679a4

Revert "Scan immune spaces using mod union tables."

This reverts commit 8256da35feac0ba7589fcd4b692a4b9a936679a4.

Test failing.

Change-Id: I391dcbdba19c6f6313e06075b0a69ea406c7c50e

runtime/gc/collector/concurrent_copying.cc

diff --git a/runtime/gc/collector/concurrent_copying.cc b/runtime/gc/collector/concurrent_copying.cc
index 4a80089..d413a50 100644
--- a/runtime/gc/collector/concurrent_copying.cc
+++ b/runtime/gc/collector/concurrent_copying.cc
@@ -520,7 +520,7 @@
   explicit ImmuneSpaceScanObjVisitor(ConcurrentCopying* cc)
       : collector_(cc) {}
 
-  ALWAYS_INLINE void operator()(mirror::Object* obj) const SHARED_REQUIRES(Locks::mutator_lock_) {
+  void operator()(mirror::Object* obj) const SHARED_REQUIRES(Locks::mutator_lock_) {
     if (kUseBakerReadBarrier && kGrayDirtyImmuneObjects) {
       if (obj->GetReadBarrierPointer() == ReadBarrier::GrayPtr()) {
         collector_->ScanImmuneObject(obj);
@@ -534,10 +534,6 @@
     }
   }
 
-  static void Callback(mirror::Object* obj, void* arg) SHARED_REQUIRES(Locks::mutator_lock_) {
-    reinterpret_cast<ImmuneSpaceScanObjVisitor*>(arg)->operator()(obj);
-  }
-
  private:
   ConcurrentCopying* const collector_;
 };
@@ -562,15 +558,10 @@
     for (auto& space : immune_spaces_.GetSpaces()) {
       DCHECK(space->IsImageSpace() || space->IsZygoteSpace());
       accounting::ContinuousSpaceBitmap* live_bitmap = space->GetLiveBitmap();
-      accounting::ModUnionTable* table = heap_->FindModUnionTableFromSpace(space);
       ImmuneSpaceScanObjVisitor visitor(this);
-      if (table != nullptr) {
-        table->VisitObjects(ImmuneSpaceScanObjVisitor::Callback, &visitor);
-      } else {
-        live_bitmap->VisitMarkedRange(reinterpret_cast<uintptr_t>(space->Begin()),
-                                      reinterpret_cast<uintptr_t>(space->Limit()),
-                                      visitor);
-      }
+      live_bitmap->VisitMarkedRange(reinterpret_cast<uintptr_t>(space->Begin()),
+                                    reinterpret_cast<uintptr_t>(space->Limit()),
+                                    visitor);
     }
   }
   if (kUseBakerReadBarrier) {