commit 9450c6c25833e8353e436bbd0491ed96cd80f34f
author Mathieu Chartier <mathieuc@google.com> Sat Nov 07 11:55:23 2015 -0800
committer Mathieu Chartier <mathieuc@google.com> Sat Nov 07 12:04:08 2015 -0800
tree 163416d7a0e31dccf918ac0e0ddcf11b4df5075a
parent 2264f624e41acf09b17c3961bd52966e43f2b58f

Remove thread suspension assertion for SuspendAllForDebugger

Fixes race condition that occasionally caused an assertion failure
for debugger tests, description in comments.

Change-Id: I18e003e01c1711dfdb0dd68ccb3d2b7dc626991f

runtime/thread_list.cc

diff --git a/runtime/thread_list.cc b/runtime/thread_list.cc
index b09b87f..a390908 100644
--- a/runtime/thread_list.cc
+++ b/runtime/thread_list.cc
@@ -948,7 +948,12 @@
   Locks::mutator_lock_->ExclusiveLock(self);
   Locks::mutator_lock_->ExclusiveUnlock(self);
 #endif
-  AssertThreadsAreSuspended(self, self, debug_thread);
+  // Disabled for the following race condition:
+  // Thread 1 calls SuspendAllForDebugger, gets preempted after pulsing the mutator lock.
+  // Thread 2 calls SuspendAll and SetStateUnsafe (perhaps from Dbg::Disconnected).
+  // Thread 1 fails assertion that all threads are suspended due to thread 2 being in a runnable
+  // state (from SetStateUnsafe).
+  // AssertThreadsAreSuspended(self, self, debug_thread);
 
   VLOG(threads) << *self << " SuspendAllForDebugger complete";
 }