tree 8e7600204eed1509b7ec436ae789f3d8195a8755
parent dc47e986941b1a3754447fabea272485f3f0f382
author Mathieu Chartier <mathieuc@google.com> 1425419464 -0800
committer Mathieu Chartier <mathieuc@google.com> 1425429109 -0800

Wait for threads to finish unregistering

There was a race where Thread::join would return before the thread was
unregistered. This caused a problem with Daemons.stop since the thread
list could get deleted before the daemon thread was removed from list_.
This caused occasional "Request to unregister unattached thread"
errors and warnings.

The fix is to wait until threads finish registering before destroying
the thread list. The only threads which can be unregistering at this
point are the daemons we stopped earlier during the runtime shutdown
process. The issue is that thread join finishes before we remove the
thread from the thread list.

Also some cleanup.

Bug: 18713034
Change-Id: I8921122fe8462643a6b814b5f00632481e3831fb