commit 90bcbd50aca23331869f64a2ecb8e6c292c127ff
author Jeff Hao <jeffhao@google.com> Thu May 14 17:19:15 2015 -0700
committer Jeff Hao <jeffhao@google.com> Thu May 14 17:58:46 2015 -0700
tree 46d04086aaafd8a6d4a015df66865d04ed426ac8
parent 961445587ade0ba26f9bbd4d66853e75d446c057

In hprof, use an address within string for char array of empty string.

Bug: 21089461

(cherry picked from commit I203345caf74fba2e9bf0549256147d84d1bb829e)

Change-Id: I38d1bc0d303558ab535ec4c3aa17a046fcb055a1

runtime/hprof/hprof.cc

diff --git a/runtime/hprof/hprof.cc b/runtime/hprof/hprof.cc
index 868cb23..efead51 100644
--- a/runtime/hprof/hprof.cc
+++ b/runtime/hprof/hprof.cc
@@ -1150,13 +1150,20 @@
   // Output native value character array for strings.
   if (orig_klass->IsStringClass()) {
     mirror::String* s = obj->AsString();
-    __ AddObjectId(reinterpret_cast<mirror::Object*>(s->GetValue()));
+    mirror::Object* value;
+    if (s->GetLength() == 0) {
+      // If string is empty, use an object-aligned address within the string for the value.
+      value = reinterpret_cast<mirror::Object*>(reinterpret_cast<uintptr_t>(s) + kObjectAlignment);
+    } else {
+      value = reinterpret_cast<mirror::Object*>(s->GetValue());
+    }
+    __ AddObjectId(value);
 
     // Patch the instance field length.
     __ UpdateU4(size_patch_offset, output_->Length() - (size_patch_offset + 4));
 
     __ AddU1(HPROF_PRIMITIVE_ARRAY_DUMP);
-    __ AddObjectId(reinterpret_cast<mirror::Object*>(s->GetValue()));
+    __ AddObjectId(value);
     __ AddU4(StackTraceSerialNumber(obj));
     __ AddU4(s->GetLength());
     __ AddU1(hprof_basic_char);