commit 17065880693d1b15ffeb60b9955a2d092839977f
author David Srbecky <dsrbecky@google.com> Sat Jun 20 05:01:22 2015 +0100
committer David Srbecky <dsrbecky@google.com> Sat Jun 20 05:09:22 2015 +0100
tree 518f28f4767f3144173df2c52d35c4d5f46c532c
parent f16474d08ed51a3ccfaa70360aefdf12ebc79da1

Use signed encoding when using relative CFI addresses.

This is required for gdb to work.
libunwind works with either encoding.

Bug: 21924613
Change-Id: I4e4f1cf9c65d48fa885a5993eeeed0253a3f2579

compiler/dwarf/headers.h

diff --git a/compiler/dwarf/headers.h b/compiler/dwarf/headers.h
index ad315ee..ae57755 100644
--- a/compiler/dwarf/headers.h
+++ b/compiler/dwarf/headers.h
@@ -54,9 +54,19 @@
   writer.PushUleb128(return_address_register.num());  // ubyte in DWARF2.
   writer.PushUleb128(1);  // z: Augmentation data size.
   if (is64bit) {
-    writer.PushUint8(address_type | DW_EH_PE_udata8);  // R: Pointer encoding.
+    if (address_type == DW_EH_PE_pcrel) {
+      writer.PushUint8(DW_EH_PE_pcrel | DW_EH_PE_sdata8);   // R: Pointer encoding.
+    } else {
+      DCHECK(address_type == DW_EH_PE_absptr);
+      writer.PushUint8(DW_EH_PE_absptr | DW_EH_PE_udata8);  // R: Pointer encoding.
+    }
   } else {
-    writer.PushUint8(address_type | DW_EH_PE_udata4);  // R: Pointer encoding.
+    if (address_type == DW_EH_PE_pcrel) {
+      writer.PushUint8(DW_EH_PE_pcrel | DW_EH_PE_sdata4);   // R: Pointer encoding.
+    } else {
+      DCHECK(address_type == DW_EH_PE_absptr);
+      writer.PushUint8(DW_EH_PE_absptr | DW_EH_PE_udata4);  // R: Pointer encoding.
+    }
   }
   writer.PushData(opcodes.data());
   writer.Pad(is64bit ? 8 : 4);