tree 2101ec743ca158423d81c1a134acef402a336930
parent bd64825ec45c5467af7e73b686883479d7ff9078
author Theodore Ts'o <tytso@mit.edu> 1629517457 -0400
committer Eva Huang <evahuang@google.com> 1634789029 +0000

ext4: fix race writing to an inline_data file while its xattrs are changing

commit a54c4613dac1500b40e4ab55199f7c51f028e848 upstream.

The location of the system.data extended attribute can change whenever
xattr_sem is not taken.  So we need to recalculate the i_inline_off
field since it mgiht have changed between ext4_write_begin() and
ext4_write_end().

This means that caching i_inline_off is probably not helpful, so in
the long run we should probably get rid of it and shrink the in-memory
ext4 inode slightly, but let's fix the race the simple way for now.

Bug: 199579676
Cc: stable@vger.kernel.org
Fixes: f19d5870cbf72 ("ext4: add normal write support for inline data")
Reported-by: syzbot+13146364637c7363a7de@syzkaller.appspotmail.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Change-Id: I05a5e6fbadff242ae45fb6530e9afc1b6f635c01