tree 66506c624ddfddb92d672d14abba1cd3775e6bde
parent 6c8412eb0e87fa57e12aeca91c46cd133152a3c1
author André Draszik <draszik@google.com> 1708353706 +0000
committer Will McVicker <willmcvicker@google.com> 1715861888 -0700

treewide: replace strlcpy() with strscpy() (v6.8 compatibility)

Linux commit [1] has removed strlcpy() and this causes this OOT pixel
driver to fail compilation.

strlcpy() reads the entire source buffer first. This read may exceed
the destination size limit. This is both inefficient and can lead
to linear read overflows if a source string is not NUL-terminated[2].
Additionally, it returns the size of the source string, not the
resulting size of the destination string. In an effort to remove
strlcpy() completely[3], replace strlcpy() here with strscpy().

Nothing here checks the return value here, so a direct replacement with
strspy() is possible. Also, since strscpy() is guaranteed to
NULL-terminate the string, we can drop the manual initialisation.

Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d26270061ae6 [1]
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy [2]
Link: https://github.com/KSPP/linux/issues/89 [3]
Test: TH
Bug: 292499021
Change-Id: I4f184946ee21afa0a852a198f585fe7c05a35bdf
Signed-off-by: André Draszik <draszik@google.com>