Revert "Change mincore() to count "mapped" pages rather than "cached" pages"
This reverts commit 574823bfab82d9d8fa47f422778043fbb4b4f50e.
It turns out that my hope that we could just remove the code that
exposes the cache residency status from mincore() was too optimistic.
There are various random users that want it, and one example would be
the Netflix database cluster maintenance. To quote Josh Snyder:
"For Netflix, losing accurate information from the mincore syscall
would lengthen database cluster maintenance operations from days to
months. We rely on cross-process mincore to migrate the contents of a
page cache from machine to machine, and across reboots.
To do this, I wrote and maintain happycache , a page cache
dumper/loader tool. It is quite similar in architecture to pgfincore,
except that it is agnostic to workload. The gist of happycache's
operation is "produce a dump of residence status for each page, do
some operation, then reload exactly the same pages which were present
before." happycache is entirely dependent on accurate reporting of the
in-core status of file-backed pages, as accessed by another process.
We primarily use happycache with Cassandra, which (like Postgres +
pgfincore) relies heavily on OS page cache to reduce disk accesses.
Because our workloads never experience a cold page cache, we are able
to provision hardware for a peak utilization level that is far lower
than the hypothetical "every query is a cache miss" peak.
A database warmed by happycache can be ready for service in seconds
(bounded only by the performance of the drives and the I/O subsystem),
with no period of in-service degradation. By contrast, putting a
database in service without a page cache entails a potentially
unbounded period of degradation (at Netflix, the time to populate a
single node's cache via natural cache misses varies by workload from
hours to weeks). If a single node upgrade were to take weeks, then
upgrading an entire cluster would take months. Since we want to apply
security upgrades (and other things) on a somewhat tighter schedule,
we would have to develop more complex solutions to provide the same
functionality already provided by mincore.
At the bottom line, happycache is designed to benignly exploit the
same information leak documented in the paper . I think it makes
perfect sense to remove cross-process mincore functionality from
unprivileged users, but not to remove it entirely"
We do have an alternate approach that limits the cache residency
reporting only to processes that have write permissions to the file, so
we can fix the original information leak issue that way. It involves
_adding_ code rather than removing it, which is sad, but hey, at least
we haven't found any users that would find the restrictions
So revert the optimistic first approach to make room for that alternate
Reported-by: Josh Snyder <firstname.lastname@example.org>
Cc: Jiri Kosina <email@example.com>
Cc: Dominique Martinet <firstname.lastname@example.org>
Cc: Andy Lutomirski <email@example.com>
Cc: Dave Chinner <firstname.lastname@example.org>
Cc: Kevin Easton <email@example.com>
Cc: Matthew Wilcox <firstname.lastname@example.org>
Cc: Cyril Hrubis <email@example.com>
Cc: Vlastimil Babka <firstname.lastname@example.org>
Cc: Tejun Heo <email@example.com>
Cc: Kirill A. Shutemov <firstname.lastname@example.org>
Cc: Daniel Gruss <email@example.com>
Signed-off-by: Linus Torvalds <firstname.lastname@example.org>
1 file changed