commit fa8ee0ad6dbb22bb9962c3e32c091f29c2e0d5d8
author Dandan Bi <dandan.bi@intel.com> Fri Apr 22 11:29:12 2016 +0800
committer Star Zeng <star.zeng@intel.com> Mon Apr 25 15:03:05 2016 +0800
tree 6480a7e1790f139e1e0a03ca6ea04fa6942df830
parent ae6945b61b1511e2fc4c4441794ff1877aa9abe4

MdeModulePkg/SetupBrowserDxe: Remove the useless check

When the type of HiiValue is BUFFER Type, the BufferValue
of the related question can not be NULL, so can remove the
check.

Cc: Qiu Shumin <shumin.qiu@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>

MdeModulePkg/Universal/SetupBrowserDxe/Setup.c

diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
index c36588e..5887e0f 100644
--- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
+++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
@@ -3919,7 +3919,7 @@
   //

   HiiValue = &Question->HiiValue;

   TypeValue = &HiiValue->Value;

-  if (HiiValue->Type == EFI_IFR_TYPE_BUFFER && Question->BufferValue != NULL) {

+  if (HiiValue->Type == EFI_IFR_TYPE_BUFFER) {

     //

     // For orderedlist, need to pass the BufferValue to Callback function.

     //