commit 1e124de0188e6e3ed557500cc429cf7a756786d3
author Hao Wu <hao.a.wu@intel.com> Fri Sep 30 10:41:26 2016 +0800
committer Hao Wu <hao.a.wu@intel.com> Tue Nov 08 16:37:54 2016 +0800
tree fa3d1f025113f54211008936cf8e5ef356fd10be
parent 85006654944a0f9e64974f23705beb7bc4906bcc

BaseTools/EfiRom: Fix file handles not being closed

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>

BaseTools/Source/C/EfiRom/EfiRom.c

diff --git a/BaseTools/Source/C/EfiRom/EfiRom.c b/BaseTools/Source/C/EfiRom/EfiRom.c
index 2e51315..c58c152 100644
--- a/BaseTools/Source/C/EfiRom/EfiRom.c
+++ b/BaseTools/Source/C/EfiRom/EfiRom.c
@@ -176,9 +176,6 @@
 

 BailOut:

   if (Status == STATUS_SUCCESS) {

-    if (FptrOut != NULL) {

-      fclose (FptrOut);

-    }

     //

     // Clean up our file list

     //

@@ -189,6 +186,10 @@
     }

   }

 

+  if (FptrOut != NULL) {

+    fclose (FptrOut);

+  }

+

   if (mOptions.Verbose) {

     VerboseMsg("%s tool done with return code is 0x%x.\n", UTILITY_NAME, GetUtilityStatus ());

   }