Google Git
Sign in
android/device/google/cuttlefish/a7d096765
commit
a7d096765b16cee30786f7de7c20ce11f549dbc6
[log]
author
A. Cody Schuffelen <schuffelen@google.com>
Fri Feb 12 16:22:39 2021 -0800
committer
Ram Muthiah <rammuthiah@google.com>
Tue Jun 08 19:32:32 2021 +0000
tree
1a19093ec12c46043471600595ec0504d7c05e5c
parent
6620b244e580cf84dbf4e58d762109dbad0f96e7 [diff]
Use android::base::EndsWith rather than custom suffix testing.

The custom suffix testing had a bug that could cause short filenames to
unexpectedly produce matches for each other. If the string "abc" was
tested if it matched the suffix "zxcv" it would unexpectedly match it.
This is because `expected_pos = file.size() - suffix.size()` would
unintentionally match the result of `file.rfind(suffix)` when
`suffix.size() == file.size() + 1`, because `rfind` returns
std::string::npos on no match, which is also -1.

This problem was previously unlikely with absolute path filenames, but
causes a lot of spurious matches with local file paths (aosp/1582769).
The absolute path filenames were much longer than the local filenames.

Bug: 178677060
Bug: 169261091
Bug: 182328055
Test: Treehugger
Change-Id: I132d3d00dadc21ad8789ca6cb02b313d3b73be88
Merged-In: I132d3d00dadc21ad8789ca6cb02b313d3b73be88
1 file changed
tree: 1a19093ec12c46043471600595ec0504d7c05e5c
  1. common/
  2. guest/
  3. host/
  4. shared/
  5. tests/
  6. tools/
  7. vsoc_arm64/
  8. vsoc_x86/
  9. vsoc_x86_64/
  10. vsoc_x86_noapex/
  11. Android.bp
  12. Android.mk
  13. AndroidProducts.mk
  14. CleanSpec.mk
  15. default-permissions.xml
  16. dtb.img
  17. fetcher.mk
  18. host_package.mk
  19. OWNERS
  20. README.md
  21. TEST_MAPPING
README.md

So you want to try cuttlefish?

  1. Download, build, and install the host debian package:
git clone https://github.com/google/android-cuttlefish
cd android-cuttlefish
debuild -i -us -uc -b
sudo dpkg -i ../cuttlefish-common_*_amd64.deb
sudo apt-get install -f
  1. Go to http://ci.android.com/
  2. Enter a branch name. Start with aosp-master if you don‘t know what you’re looking for
  3. Navigate to aosp_cf_x86_phone and click on userdebug for the latest build
  4. Click on Artifacts
  5. Scroll down to the OTA images. These packages look like aosp_cf_x86_phone-img-xxxxxx.zip -- it will always have img in the name. Download this file
  6. Scroll down to cvd-host_package.tar.gz. You should always download a host package from the same build as your images.
  7. On your local system, combine the packages:
mkdir cf
cd cf
tar xvf /path/to/cvd-host_package.tar.gz
unzip /path/to/aosp_cf_x86_phone-img-xxxxxx.zip

  1. Launch cuttlefish with:

    $ HOME=$PWD ./bin/launch_cvd

  2. Stop cuttlefish with:

    $ HOME=$PWD ./bin/stop_cvd

So you want to debug cuttlefish?

You can use adb to debug it, just like a physical device:

$ ./bin/adb -e shell

So you want to see cuttlefish?

You can use the TightVNC JViewer. Once you have downloaded the TightVNC Java Viewer JAR in a ZIP archive, run it with

$ java -jar tightvnc-jviewer.jar -ScalingFactor=50 -Tunneling=no -host=localhost -port=6444

Click “Connect” and you should see a lock screen!