Revert "Mount system_other with AVB verification."
This reverts commit dad923662fed86a8af0315dd5970d7a133a570db.
system_other won't be updated during OTA and it might contain AVB
metadata leftover from previous flash. When it happens, device might
fail to boot because of incorrect dm-verity-fec settings.
e.g.,
device-mapper: verity-fec: 259:36: FEC: recursion too deep
This only happens on A/B devices with PRODUCT_RETROFIT_DYNAMIC_PARTITIONS
set to true, where system_other is a physical partition with the
AVB metadata located at the end of the partition. The active slot
contains primary logical images.
A possible scenario will be:
a. system_b partition is installed with system_other.img, and AVB
footer is at the end of system_b.
b. First time OTA to install logical images to system_b and
mark _b as the active slot. But AVB footer of system_other from
step-a isn't cleared. e.g., the logical images don't use up to
the end of system_b.
c. Second time OTA to install logical images to system_a and mark _a
as the active slot.
d. Factory wipe the device, which triggers the mounting of
system_other. The leftover of AVB footer from step-a doesn't match
the leftover of the filesystem data from step-b, then triggers this
error.
Bug: 129032485
Bug: 139402097
Test: tree hugger
Change-Id: I3cb25117fcab29cd41add978685c6844822acbdc
Merged-In: I3cb25117fcab29cd41add978685c6844822acbdc
(cherry picked from commit 7980a977ee31bd6584cd93959c4e12fadacf45d5)
(cherry picked from commit 2cf4bd101761af9eb0b2f821d7bee9588a176b7a)
2 files changed