blob: 8ca16e1eebb3e23f0be9d1de1eca6208e78044b3 [file] [log] [blame]
/*
* Copyright 2003-2012 Dave Griffith, Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.internationalization;
import com.intellij.psi.CommonClassNames;
import com.intellij.psi.PsiBinaryExpression;
import com.intellij.psi.PsiExpression;
import com.intellij.psi.PsiKeyword;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.psiutils.ComparisonUtils;
import com.siyeh.ig.psiutils.ExpressionUtils;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
public class CharacterComparisonInspection extends BaseInspection {
@Override
@NotNull
public String getID() {
return "CharacterComparison";
}
@Override
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message("character.comparison.display.name");
}
@Override
@NotNull
public String buildErrorString(Object... infos) {
return InspectionGadgetsBundle.message("character.comparison.problem.descriptor");
}
@Override
public BaseInspectionVisitor buildVisitor() {
return new CharacterComparisonVisitor();
}
private static class CharacterComparisonVisitor extends BaseInspectionVisitor {
@Override
public void visitBinaryExpression(@NotNull PsiBinaryExpression expression) {
super.visitBinaryExpression(expression);
final PsiExpression rhs = expression.getROperand();
if (!ComparisonUtils.isComparison(expression) || ComparisonUtils.isEqualityComparison(expression)) {
return;
}
final PsiExpression lhs = expression.getLOperand();
if (!isCharacter(lhs) || !isCharacter(rhs)) {
return;
}
if (NonNlsUtils.isNonNlsAnnotated(lhs) || NonNlsUtils.isNonNlsAnnotated(rhs)) {
return;
}
registerError(expression);
}
private static boolean isCharacter(@Nullable PsiExpression expression) {
return ExpressionUtils.hasType(expression, PsiKeyword.CHAR) ||
ExpressionUtils.hasType(expression, CommonClassNames.JAVA_LANG_CHARACTER);
}
}
}