blob: c574dde7a17c3db475703b8df91011812377c816 [file] [log] [blame]
/*
* Copyright 2003-2011 Dave Griffith, Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.bugs;
import com.intellij.codeInsight.AnnotationUtil;
import com.intellij.codeInsight.NullableNotNullManager;
import com.intellij.codeInspection.AnnotateMethodFix;
import com.intellij.codeInspection.ui.MultipleCheckboxOptionsPanel;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import com.intellij.psi.util.PsiTreeUtil;
import com.intellij.util.ArrayUtil;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.DelegatingFix;
import com.siyeh.ig.InspectionGadgetsFix;
import com.siyeh.ig.psiutils.CollectionUtils;
import org.intellij.lang.annotations.Pattern;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import javax.swing.*;
public class ReturnNullInspectionBase extends BaseInspection {
@SuppressWarnings({"PublicField"})
public boolean m_reportObjectMethods = true;
@SuppressWarnings({"PublicField"})
public boolean m_reportArrayMethods = true;
@SuppressWarnings({"PublicField"})
public boolean m_reportCollectionMethods = true;
@SuppressWarnings({"PublicField"})
public boolean m_ignorePrivateMethods = false;
@Override
@Pattern("[a-zA-Z_0-9.-]+")
@NotNull
public String getID() {
return "ReturnOfNull";
}
@Override
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message("return.of.null.display.name");
}
@Override
@NotNull
public String buildErrorString(Object... infos) {
return InspectionGadgetsBundle.message(
"return.of.null.problem.descriptor");
}
@Override
@Nullable
protected InspectionGadgetsFix buildFix(Object... infos) {
final PsiElement elt = (PsiElement)infos[0];
if (!AnnotationUtil.isAnnotatingApplicable(elt)) {
return null;
}
final NullableNotNullManager manager =
NullableNotNullManager.getInstance(elt.getProject());
return new DelegatingFix(new AnnotateMethodFix(
manager.getDefaultNullable(),
ArrayUtil.toStringArray(manager.getNotNulls())){
@Override
public int shouldAnnotateBaseMethod(PsiMethod method, PsiMethod superMethod, Project project) {
return ReturnNullInspectionBase.this.shouldAnnotateBaseMethod(method, superMethod);
}
});
}
protected int shouldAnnotateBaseMethod(PsiMethod method, PsiMethod superMethod) {
return 1;
}
@Override
public JComponent createOptionsPanel() {
final MultipleCheckboxOptionsPanel optionsPanel =
new MultipleCheckboxOptionsPanel(this);
optionsPanel.addCheckbox(InspectionGadgetsBundle.message(
"return.of.null.ignore.private.option"),
"m_ignorePrivateMethods");
optionsPanel.addCheckbox(InspectionGadgetsBundle.message(
"return.of.null.arrays.option"), "m_reportArrayMethods");
optionsPanel.addCheckbox(InspectionGadgetsBundle.message(
"return.of.null.collections.option"),
"m_reportCollectionMethods");
optionsPanel.addCheckbox(InspectionGadgetsBundle.message(
"return.of.null.objects.option"), "m_reportObjectMethods");
return optionsPanel;
}
@Override
public BaseInspectionVisitor buildVisitor() {
return new ReturnNullVisitor();
}
private class ReturnNullVisitor extends BaseInspectionVisitor {
@Override
public void visitLiteralExpression(
@NotNull PsiLiteralExpression value) {
super.visitLiteralExpression(value);
final String text = value.getText();
if (!PsiKeyword.NULL.equals(text)) {
return;
}
PsiElement parent = value.getParent();
while (parent instanceof PsiParenthesizedExpression ||
parent instanceof PsiConditionalExpression ||
parent instanceof PsiTypeCastExpression) {
parent = parent.getParent();
}
if (!(parent instanceof PsiReturnStatement)) {
return;
}
final PsiMethod method =
PsiTreeUtil.getParentOfType(value, PsiMethod.class);
if (method == null) {
return;
}
if (m_ignorePrivateMethods &&
method.hasModifierProperty(PsiModifier.PRIVATE)) {
return;
}
final PsiType returnType = method.getReturnType();
if (returnType == null) {
return;
}
final boolean isArray = returnType.getArrayDimensions() > 0;
final NullableNotNullManager nullableNotNullManager =
NullableNotNullManager.getInstance(method.getProject());
if (nullableNotNullManager.isNullable(method, false)) {
return;
}
if (CollectionUtils.isCollectionClassOrInterface(returnType)) {
if (m_reportCollectionMethods) {
registerError(value, value);
}
}
else if (isArray) {
if (m_reportArrayMethods) {
registerError(value, value);
}
}
else {
if (m_reportObjectMethods) {
registerError(value, value);
}
}
}
}
}