tag b9ef33a8279179ec11fa04c7886819c4f1ef9b28
tagger The Android Open Source Project <initial-contribution@android.com> Tue Sep 08 18:50:06 2020 -0700
object 75aac1184eb74e36f6691f3d4896b650ce7dd63b

Android 10.0.0 release 46

commit 75aac1184eb74e36f6691f3d4896b650ce7dd63b
author Svet Ganov <svetoslavganov@google.com> Thu Sep 26 22:12:53 2019 -0700
committer Huizi Yang <yanghuiz@google.com> Tue Oct 15 19:12:39 2019 -0700
tree aed8c74716bb3815f4a334ceb47c9912f8e9f0ad
parent f62c52592816c081f485f8735c3c4aa52970932f

Update PermissionChecker usages to avoid unnecessary attribution.

We had accidental usages of the PermissionChecker for cases where no
private data was provided to the app but the checkPermission API on
the latter also did blame data access on the app. The PermissionChecker
was designed to handle IPC calls and not for generic API checks.

To avoid future accidental incorrect PermissionChecker usages this
change renames the existing APIs of the latter to clearly indicate
that they should be used for data delivery and also adds sibling
methods for doing the same permission checks for preflight purposes.
Also the documentation is improved to furhter assist developers.

In addition, this change fixes accidental permission checker usages
that blame when they should not by using the new preflight flavor
of the permission check APIs.

Test:
    atest com.android.settingslib.location.RecentLocationAppsTest
    atest CtsPermissionTestCases
    added: LocationAccessCheckTest#notificationOnlyForAccessesSinceFeatureWasEnabled
    added: LocationAccessCheckTest#noNotificationIfFeatureDisabled
    added: LocationAccessCheckTest#noNotificationIfBlamerNotSystemOrLocationProvider
    added: LocationAccessCheckTest#testOpeningLocationSettingsDoesNotTriggerAccess

bug:141028068
Merged-In: I24e7f16f70ab183a9515e6e298d21ccb9006c3cf
Change-Id: I24e7f16f70ab183a9515e6e298d21ccb9006c3cf
(cherry picked from commit a8ffa3c6063cbf38af2202a63d3358ed4ac9b0d3)